Skip to content

Use major version ref of arduino/compile-sketches action #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Use major version ref of arduino/compile-sketches action #24

merged 1 commit into from
Sep 27, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Sep 24, 2021

The arduino/compile-sketches GitHub Actions action is used by the CI system to compile the library's example sketches
for each of the supported boards in order to provide a "smoke test". Previously, due to the use of an older modified
variant of Arduino CLI, a specific ref of the action had to be used (#20). The variant of Arduino CLI has since been brought up to date, allowing it to be used with the current version of the action.

Use of the major version ref will cause the workflow to use a stable version of the action while also benefit from
ongoing development to the action up until such time as a new major release of an action is made, at which time we would
need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release
before updating the major ref (e.g., uses: arduino/compile-sketches@v2).

The `arduino/compile-sketches` GitHub Actions action is used by the CI system to compile the library's example sketches
for each of the supported boards in order to provide a "smoke test". Previously, due to the use of an older modified
variant of Arduino CLI, a specific ref of the action had to be used. The variant of Arduino CLI has since been brought up to date, allowing it to be used with the current version of the action.

Use of the major version ref will cause the workflow to use a stable version of the action while also benefit from
ongoing development to the action up until such time as a new major release of an action is made, at which time we would
need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release
before updating the major ref (e.g., uses: `arduino/compile-sketches@v2`).
@per1234 per1234 mentioned this pull request Sep 24, 2021
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific! Great work! Thank you @per1234, @facchinm 🚀

@aentinger aentinger merged commit 2dedee8 into arduino-libraries:master Sep 27, 2021
@aentinger aentinger deleted the action-ref branch September 27, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants